[05:59:02] <kassim>	 semantic maps ignores the format parameter in ask queries when a distance query is present
[06:58:19] <Saruman>	 kassim: have you filed a bug?
[07:02:20] <kassim>	 Saruman, no I have not. could you tell me how that works?
[07:03:04] <Saruman>	 sure. Visit https://bugzilla.wikimedia.org/
[07:03:33] <Saruman>	 create an account, log in, then select "enter a bug report"
[07:05:00] <kassim>	 thanks
[07:05:02] <Saruman>	 select "MediaWiki extensions", then component Semantic Maps, etc
[07:05:41] <Saruman>	 if possible, create an example of the error on a publicly accessible page on your wiki, and provide that URL
[07:06:20] <Saruman>	 A good bug report costs you some time, maybe 15 minutes
[07:06:28] <kassim>	 actually I just got it to work so maybe its not a bug after all
[07:06:47] <Saruman>	 good to hear
[07:07:02] <Saruman>	 remember the bug report thing anyway, please
[07:07:21] <kassim>	 sure
[16:47:59] <gerrit-wm>	 New patchset: Foxtrott; "Add method Subobject::addPropertyObjectValue" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/59052
[18:02:49] <gerrit-wm>	 New review: Mwjames; "I'm not entirely happy with this change because suddenly you are forcing to raise a potential except..." [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/59052
[18:12:45] <gerrit-wm>	 New review: Foxtrott; "I wanted to avoid checking on instanceof \SMWDIProperty again. I'll include a check." [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/59052
[18:25:21] <gerrit-wm>	 New patchset: Mwjames; "Add 'Has improper value for' test which not causes an exception" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/59056
[18:28:13] <gerrit-wm>	 New review: Mwjames; "Wait a second I added the test [1] 'Has improper value for' before your change which also takes care..." [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/59052
[18:30:23] <gerrit-wm>	 Change merged: jenkins-bot; [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/59056
[18:34:04] <gerrit-wm>	 New review: Mwjames; "By not checking !$propertyDi->isInverse() at first you let the factory method believe it would be OK..." [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/59052
[18:39:38] <gerrit-wm>	 New review: Foxtrott; "Hmm, seems there really is no way around basically duplicating addPropertyValue, right?" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/59052
[18:45:03] <gerrit-wm>	 New patchset: Mwjames; "Split up responsibility and move diff update into DiffData" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/57701
[18:45:03] <gerrit-wm>	 New patchset: Mwjames; "Decouple responsibility, move value factory out of ParserData" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/59057
[18:54:58] <gerrit-wm>	 New review: Mwjames; "Well addPropertyValue() as a method has a general problem because it does several things at once han..." [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/59052
[19:07:22] <gerrit-wm>	 New review: Foxtrott; "Maybe I lost you there, but " [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/59052
[19:10:34] <gerrit-wm>	 New review: Mwjames; "I really need this reviewed as soon as possible since it can solve the dependency issue in" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/59057
[19:17:00] <gerrit-wm>	 New review: Mwjames; "All the dependencies are handled by SMWDataValueFactory because its always returns an DataValue obje..." [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/59052
[19:26:14] <gerrit-wm>	 New review: Mwjames; "For example [1] had the some problem of doing multiple things at once because it needed to know some..." [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/59052
[19:35:04] <gerrit-wm>	 New review: Foxtrott; "Sounds good. So now we wait for somebody to check I0811692033 and then adapt Subobjects::addProperty..." [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/59052
[19:41:10] <gerrit-wm>	 New review: Mwjames; "Exactly, I'll do the adjustment on addPropertyValue() once the change is merged (I'm not going to do..." [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/59052
[19:46:08] <gerrit-wm>	 New review: Foxtrott; "Ok, cool." [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/59052