[00:11:27] New patchset: Mwjames; "SMW\RecurringEvents eliminate restrictions and use subobjects as object storage" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/50592 [00:14:53] New review: Mwjames; "Added RecurringEventsTest which should cover examples as in [1]." [mediawiki/extensions/SemanticMediaWiki] (master) C: 1; - https://gerrit.wikimedia.org/r/50592 [01:18:32] New patchset: Mwjames; "SMW\RecurringEvents eliminate restrictions and use subobjects as object storage" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/50592 [01:19:01] New patchset: Mwjames; "SMW\RecurringEvents eliminate restrictions and use subobjects as object storage" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/50592 [17:32:27] New review: Jeroen De Dauw; "(10 comments)" [mediawiki/extensions/SemanticMediaWiki] (master) C: -1; - https://gerrit.wikimedia.org/r/50592 [19:58:11] New patchset: Mwjames; "SMW\RecurringEvents eliminate restrictions and use subobjects as object storage" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/50592 [19:58:30] New review: Mwjames; "(8 comments)" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/50592 [21:31:47] hey yaron, dumb question, in ED, code is indented with tabs [21:32:01] my editor replaces tabs with 8 spaces [21:32:19] should I go through and 'tabify' my code when I submit the patch? [21:32:34] Sure, if you can.... it's not a big deal if you can't. [21:32:41] In general I prefer spaces for layout [21:32:44] yup, no probs [21:33:15] took me longer than expected to sit down to debug the code, but it seems good now. [21:33:34] I'll send a patch to HEAD by email [22:02:18] New patchset: Yaron Koren; "Added support for SMW's SQLStore3 (finally) for remote autocompletion" [mediawiki/extensions/SemanticForms] (master) - https://gerrit.wikimedia.org/r/50710 [22:04:11] done [22:07:18] Change merged: Yaron Koren; [mediawiki/extensions/SemanticForms] (master) - https://gerrit.wikimedia.org/r/50710 [22:50:43] dbolser_: the patch looks good, though I think there could be a better name for this parser function. [22:53:05] yaron: right, thought abotu that too [22:53:30] named it roughly in the style of #for_et and #store_et [22:53:40] Yes. [22:53:46] '#templatae_et' [22:53:56] '#templatae_for_et' ? [22:54:00] or similar? [22:54:37] I don't know - I thought about some other possibilities: #display_external_table, #for_external_table_and_template... [22:55:58] heh... it's not easy :-) [22:56:04] both are good [22:56:42] seems 'for_external_table' could have a template parameter? [22:56:57] Yes, that's another possiblity. [22:57:13] can't remember why we dismissed that [22:57:24] Have the same parser function, but different behavior depending on whether it has "template" and "data" parameters. [22:57:27] I guess it's a bit confusing [22:57:31] yup [22:57:37] Yes. I don't recall dismissing that, by the way... [22:57:45] Though I guess we're dismissing it now. :) [22:58:08] I don't remember for sure, perhaps it was just one of a number of options we discussed [22:58:26] ;-_ [22:58:33] ;-) [22:58:54] display_external_table... isn't quite right, but is the one I like most so far [22:59:12] #template_for_external_table? [22:59:36] Hm, yes... that fits all the criteria, but it might be a little "too clever". [23:00:37] you have the most experience, so I'm happy for you to decide (I don't feel strongly :-) [23:00:58] (unless you suggest #something_random ;-) [23:01:02] Okay, I'll think about it some more - I'm glad you're open-minded about the whole thing! [23:01:08] hehe [23:01:29] Well, I thought about "#pass_external_table", but I decided against it. :) [23:02:07] is '#template_external_table' clear enough? [23:02:44] Maybe, I don't know... it's somewhat ungrammatical. [23:02:53] yeah [23:03:09] but perhaps a reasonable compromise [23:03:21] I'm off to use this in anger [23:03:32] Er, what? [23:03:34] should improve integration on my site :-) [23:03:37] (if it works) [23:03:51] http://english.stackexchange.com/questions/30939/is-used-in-anger-a-britishism-for-something [23:04:22] Ah! [23:04:28] I had no idea about that one. [23:04:35] that's a bad link for giving a clear defintion though... [23:04:44] So what does "Look Back in Anger" mean? [23:04:48] 'use to do something real' is what I meant [23:04:54] not sure... [23:05:10] I think it's just ... er... [23:05:19] Alright - I'm only somewhat less confused than before, then. :) [23:05:52] it is generally used in British English to mean used for its intended purpose, or used for real rather than in tests [23:05:58] you have to scroll down a bit [23:06:24] I saw that, but now I don't know if that's *always* what it means. [23:06:41] it's what I've always thought it means ;-) [23:07:01] Look back in anger just seems to be a phrase [23:07:33] that's an awesome play actually [23:07:38] saw it on TV once [23:08:05] Alright. Well, this may require more research. :) [23:08:30] lets call the parser function '#look_back_in_anger' ;-) [23:09:26] I think we've got a winner!