[02:21:40] So, how can I access the value of SMWSQLStore3::$di_type_tables? [02:21:56] It seems to be kind of critical for iterating through all the different types of relations. [02:23:42] The description of SMWSQLStore3::getPropertyTables() makes it sound like what I'm looking for, but the code seems way too complicated... [02:23:57] Maybe I'll just try it and see what I get. [11:40:04] New review: Mwjames; "Patch Set 4: Code-Review+2" [mediawiki/extensions/SemanticMediaWiki] (master) C: 2; - https://gerrit.wikimedia.org/r/48740 [11:40:23] Change merged: jenkins-bot; [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/48740 [11:47:39] New patchset: Mwjames; "Extends smw.dataItem and smw.dataItem.factory() [DO NOT MERGE]" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/49028 [13:54:05] New review: Nischayn22; "Patch Set 2:" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/47707 [16:07:05] so... [16:07:11] Hello! [16:07:24] basically, I'm trying this diff: [16:07:32] (Continuing our discussion from #mediawiki.) [16:07:50] [dbolser@localhost ExternalData]$ git diff [16:07:50] diff --git a/ED_ParserFunctions.php b/ED_ParserFunctions.php [16:07:50] index 610ddc5..7e211b7 100644 [16:07:50] --- a/ED_ParserFunctions.php [16:07:50] +++ b/ED_ParserFunctions.php [16:07:53] @@ -331,7 +331,7 @@ class EDParserFunctions { [16:07:55] } [16:07:58] $text .= $cur_expression; [16:08:00] } [16:08:03] - return $text; [16:08:05] + return $parser->internalParse( $text ); [16:08:08] } [16:08:10] [16:08:13] /** [16:08:15] sorry for pasting, wouldn't paste much more or in #mw [16:08:35] Alright. [16:08:51] seems to work OK, and shouldn't break existing code... I think... [16:09:48] but it's basically the first thing I've come up with, so I don't know if it's a good or stable solution [16:09:56] What does it do? [16:10:20] oh, in theory it allows things like "{{#for_external_table: {{template call: {{{Splicing}}} }} }} [16:10:30] Ah... cool. [16:10:48] ah, where {{{Splicing}}} is an external variable [16:10:55] What do you mean, in theory? Does it work? [16:11:11] mind you.. yeah, I dont' see redlinks to that template, for example [16:11:40] I don't understand. [16:12:06] in the above example, I'd expect to see 'red-links' to 'Template:template call' [16:12:15] because I don't have that template in my wiki [16:12:27] I see - so, it doesn't work. [16:12:38] There are variables beeing pulled back by {{{Splicing}}} [16:13:17] other This produces output: {{#for_external_table: Hello {{{Splicing}}} {{template call: {{{Splicing}}} }} }} [16:13:51] but not the template call apparently, however, preview says that 'Template Call x' is being used in the page [16:14:39] Well, that's probably because you called the parser directly, which caused it to think it was parsing that template, or something like that. [16:15:00] yaron: how should I call it? [16:15:05] I don't know. [16:15:18] heh... I'll keep playing, and asking in #mw [16:15:31] but in general, would you be happy with a patch like this for ED? [16:15:32] I mean, it's fine to call the parser directly - I'm just saying, that's why it was giving you "mixed messages". [16:15:36] Yeah, sure. [16:15:38] ic [16:15:40] cool [16:15:50] it should simplify some of the other code too [16:16:05] because .urlencode and store would not be necessary... [16:16:31] Maybe. [16:16:31] but I'm wondering if I should create a new PF [16:16:36] to be safe [16:16:39] That might be idea. [16:16:42] ideal, rather. [16:16:52] OK [16:16:59] thanks for time :-) [16:17:10] I'll submit a pull request at some point [16:18:05] Not just to be safe, but also because the ideal syntax might be different - maybe there should be a #for_external_table_call_template, that takes in a template name and a list of external variable names. [16:18:15] ...each of which are passed as parameters to that template. [16:18:33] yaron: that's what I thought first [16:18:44] but it's more generic to just 'parse' the text [16:19:02] Yes, it's more generic, but the other way might be "cleaner". [16:19:12] so people can mix parser functions, templates, formatting, whatever [16:19:31] using the above people could make SIO... [16:19:50] i.e. less code to maintain in the extension [16:20:14] Well, if it's possible, it'll be interesting to see. [16:20:34] OK, I'll play around a bit more [16:20:43] I still thing having a #store_external_table function is a good idea, whether or not it becomes possible to replicate its functionality in wikitext. [16:20:53] OK [16:21:15] yeah, teh template call works fine once the template exists [16:21:22] Oh, great. [16:21:32] You didn't think to test that before you wrote me? :) [16:21:53] Never mind, doesn't matter. [16:21:57] yaron: wanted to ask if it was an OK direction to take the extension, just can't help myself fireing off queries [16:22:02] Right. [16:22:04] :-) [16:22:08] By the way, what's a pull request? [16:22:21] oh, it's a development pattern on github [16:22:36] perhaps the MW git repo doesn't have this concept [16:22:44] Not that I'm aware of. [16:22:49] basically a logged request to apply a patch [16:22:54] so it's super easy to do [16:22:55] nm [16:23:07] Then again, there's volumes of stuff on Gerrit that I don't really understand. [16:23:08] cheers [16:23:13] hehe [16:23:15] ty [16:23:26] g2g, time to give a talk ;-P [16:24:04] Later. [18:59:59] New patchset: Foxtrott; "parameter "new window" for formlink and queryformlink" [mediawiki/extensions/SemanticForms] (master) - https://gerrit.wikimedia.org/r/48734 [19:01:24] Dangit... I just want to get the value of an arbitrary SMW_DataItem descendant, but there's no universal "convert to scalar" method other than getSerialization(), which is more than just the value. [19:08:07] hmm that sounds like an interesting incantation... [19:10:48] getSortKey() seems to return what I'm looking for, but that's got to be improper usage. [19:15:00] TheWoozle: I'm really not sure about this one, but it could be that you first need to convert it into an SMW_DataValue, using getDataValue() or something. [19:15:12] It's been a while since I looked into any of that code. [19:23:20] Hmm... let me check the class docs and see if that looks promising... [19:24:18] Yes. Yes it does. [19:25:08] Cool. [19:25:19] I'm liking the schema and class API for 1.9 a lot better than those in 1.7, by the way. They make a lot more sense. [19:27:01] Well, I wasn't involved in creating them - I only use them - but I agree with you. [19:30:59] New review: Yaron Koren; "Patch Set 2:" [mediawiki/extensions/SemanticForms] (master) - https://gerrit.wikimedia.org/r/48734 [19:44:30] New patchset: Foxtrott; "parameter "new window" for formlink and queryformlink" [mediawiki/extensions/SemanticForms] (master) - https://gerrit.wikimedia.org/r/48734 [19:52:14] New review: Yaron Koren; "Patch Set 3: Verified+2 Code-Review+2" [mediawiki/extensions/SemanticForms] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/48734 [19:52:15] Change merged: Yaron Koren; [mediawiki/extensions/SemanticForms] (master) - https://gerrit.wikimedia.org/r/48734 [20:43:53] New patchset: Yaron Koren; "Fixed handling of dollar signs in values in multiple-instance templates" [mediawiki/extensions/SemanticForms] (master) - https://gerrit.wikimedia.org/r/49155 [20:44:26] New review: Yaron Koren; "Patch Set 1: Verified+2 Code-Review+2" [mediawiki/extensions/SemanticForms] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/49155 [20:44:27] Change merged: Yaron Koren; [mediawiki/extensions/SemanticForms] (master) - https://gerrit.wikimedia.org/r/49155 [21:13:41] Has anyone here tried implementing a semantic map (or even just a map in a wiki) with custom tiles? [21:14:23] I have a wiki that will be isolated from the Internet and I was going to try and give it a basic map. [21:21:28] After upgrading from 1.7 to 1.8, property values containing a "=" character fail to display. Did someone else had this issue ? [22:27:04] New patchset: Yaron Koren; "Added compatibility with new ContentHandler approach in MW 1.21" [mediawiki/extensions/SemanticForms] (master) - https://gerrit.wikimedia.org/r/49176 [22:28:05] New review: Yaron Koren; "Patch Set 1: Verified+2 Code-Review+2" [mediawiki/extensions/SemanticForms] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/49176 [22:28:05] Change merged: Yaron Koren; [mediawiki/extensions/SemanticForms] (master) - https://gerrit.wikimedia.org/r/49176