[01:23:20] Hmm, how do I get this factbox thing to show up again? __SHOWFACTBOX__ should do the trick no? [01:28:08] New patchset: Jeroen De Dauw; "get rid of wgTitle, bug 38407" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/15680 [01:28:29] Change merged: Jeroen De Dauw; [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/15649 [01:37:43] New review: Mwjames; "makes sense" [mediawiki/extensions/SemanticMediaWiki] (master) C: 1; - https://gerrit.wikimedia.org/r/15680 [03:06:47] Change merged: Nikerabbit; [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/15680 [08:37:20] New patchset: Mwjames; "SRF re-factoring d3chart" [mediawiki/extensions/SemanticResultFormats] (master) - https://gerrit.wikimedia.org/r/15682 [08:54:26] New patchset: Mwjames; "SRF re-factoring d3chart" [mediawiki/extensions/SemanticResultFormats] (master) - https://gerrit.wikimedia.org/r/15682 [09:07:05] New patchset: Mwjames; "SRF re-factoring d3chart" [mediawiki/extensions/SemanticResultFormats] (master) - https://gerrit.wikimedia.org/r/15682 [09:15:23] New patchset: Mwjames; "SRF re-factoring d3chart" [mediawiki/extensions/SemanticResultFormats] (master) - https://gerrit.wikimedia.org/r/15682 [10:41:58] New patchset: Mwjames; "SRF re-factoring d3chart" [mediawiki/extensions/SemanticResultFormats] (master) - https://gerrit.wikimedia.org/r/15682 [17:52:34] JeroenDeDauw: Hey [17:52:51] storerewrite still not merged? [18:16:26] nischayn22: Markus still has not given an OK on it [18:16:29] nischayn22: or has he? [18:16:42] JeroenDeDauw: I see, he hasn't [18:17:16] nischayn22: I have time now and tomorrow to fix breakage, so let's merge it now [18:17:48] Change merged: Jeroen De Dauw; [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/14773 [18:18:37] great, now more work for tomorrow [18:19:51] nischayn22: anything I can help you with now? [18:20:23] JeroenDeDauw: look at line 83 here https://gerrit.wikimedia.org/r/#/c/14773/4/includes/storage/SQLStore/SMW_SQLStore3_SetupHandlers.php [18:20:33] we don't need that now, right? [18:21:50] JeroenDeDauw: plus I also have some time for writing tests, what is the next priority? [18:22:04] mostly done with the Store methods now [18:22:46] nischayn22: I guess we could get rid of it yes. When I joined the project it was at 1.4.something [18:22:53] 1.3 is over 3 years old [18:23:15] lol, Ok [18:24:17] nischayn22: I'd finish up the store rewrite [18:24:52] nischayn22: and then do the stuff such as detecting needless writes based on hash checks [18:25:08] Its done mostly, only a few fixes are to be done [18:25:16] JeroenDeDauw: hash check is done [18:25:32] its there in the new store [18:27:36] New patchset: Nischayn22; "Getting rid of old stuff" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/15687 [18:29:48] Change merged: Jeroen De Dauw; [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/15687 [18:30:32] nischayn22: oh awesome - I should have a closer look at that then [18:31:13] JeroenDeDauw: I thought you had looked already at the hash checks [18:32:07] nischayn22: at the code yes, but I never had a look at the actual difference when saving stuff [18:32:11] I'll be back in 5 [18:47:43] nischayn22: would be nice if you could isolate the SQLStore2 stuff that will be removed soonish into it's own directory [18:47:47] for instance /compat [18:48:09] JeroenDeDauw: I was thinking of doing that actually [18:58:56] New patchset: Nischayn22; "moving store2" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/15688 [19:03:57] Change merged: Jeroen De Dauw; [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/15688 [19:15:27] New patchset: Nischayn22; "Clean up" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/15689 [19:15:49] JeroenDeDauw: One more :) [19:22:30] . [19:28:52] New review: Nischayn22; "Oops! wait for my second patch, the constructor should be newFromDIType" [mediawiki/extensions/SemanticMediaWiki] (master) C: -1; - https://gerrit.wikimedia.org/r/15689 [19:35:44] New patchset: Mwjames; "SRF re-factoring d3chart" [mediawiki/extensions/SemanticResultFormats] (master) - https://gerrit.wikimedia.org/r/15682 [19:37:20] New patchset: Nischayn22; "Clean up" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/15689 [19:39:26] New review: Nischayn22; "errr" [mediawiki/extensions/SemanticMediaWiki] (master) C: 1; - https://gerrit.wikimedia.org/r/15689 [19:40:50] New patchset: Nischayn22; "Clean up" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/15689 [19:41:07] * nischayn22 should probably sleep now [19:47:55] now I hate PHP [19:53:59] Change merged: Jeroen De Dauw; [mediawiki/extensions/SemanticResultFormats] (master) - https://gerrit.wikimedia.org/r/15682 [21:17:35] nischayn22: why the sudden hate for php? (ie which of the many reasons? :p) [22:22:26] Change merged: Jeroen De Dauw; [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/15689