[07:38:04] New review: Foxtrott; "(no comment)" [mediawiki/extensions/SemanticPageSeries] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/12728 [07:38:06] Change merged: Foxtrott; [mediawiki/extensions/SemanticPageSeries] (master) - https://gerrit.wikimedia.org/r/12728 [16:34:17] New patchset: Jeroen De Dauw; "Added new tests" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/12716 [16:34:35] New review: Jeroen De Dauw; "(no comment)" [mediawiki/extensions/SemanticMediaWiki] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/12716 [16:34:37] Change merged: Jeroen De Dauw; [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/12716 [16:34:53] nischayn22: just merged your new tests [16:34:59] nischayn22: mad a small amend first though [16:35:16] nischayn22: added some assertions that always happen, even when the result is empty [16:35:24] Else PHPUnit whines about incomplete tests [16:40:22] JeroenDeDauw: I don't know why there were incomplete tests, I have passed the _MDAT property there [16:42:56] nischayn22: I'll have a closer look soonish [16:43:00] After I've eaten [16:43:07] E_OUT_OF_FOOD exception ATM [16:43:18] JeroenDeDauw: great [17:50:23] New review: Jeroen De Dauw; "(no comment)" [mediawiki/extensions/SemanticMediaWiki] (storerewrite); V: 1 C: 2; - https://gerrit.wikimedia.org/r/12715 [17:50:25] Change merged: Jeroen De Dauw; [mediawiki/extensions/SemanticMediaWiki] (storerewrite) - https://gerrit.wikimedia.org/r/12715 [17:53:00] nischayn22|Away: have you looked into doing the refactoring I suggested 2 days (or so) back? [19:40:12] JeroenDeDauw: Sorry, I don't recall, which part? [21:31:25] nischayn22|Away: using an interface for the DI handlers and moving the store field to the base class [22:05:17] New patchset: Jeroen De Dauw; "Add missing space and use number formatting - pointed out by kgh" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/12836 [22:05:50] New review: Jeroen De Dauw; "(no comment)" [mediawiki/extensions/SemanticMediaWiki] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/12836 [22:05:52] Change merged: Jeroen De Dauw; [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/12836