[00:03:34] PROBLEM - ns1 Puppet on ns1 is CRITICAL: CRITICAL: Catalog fetch fail. Either compilation failed or puppetmaster has issues [00:11:35] RECOVERY - ns1 Puppet on ns1 is OK: OK: Puppet is currently enabled, last run 1 minute ago with 0 failures [01:00:18] [02miraheze/puppet] 07Southparkfan pushed 031 commit to 03master [+0/-0/±1] 13https://git.io/fA2Xm [01:00:20] [02miraheze/puppet] 07Southparkfan 031551238 - Add hiera var for mediawiki::memcached [01:00:59] [02miraheze/puppet] 07Southparkfan pushed 031 commit to 03master [+0/-0/±1] 13https://git.io/fA2Xs [01:01:00] [02miraheze/puppet] 07Southparkfan 03b1ee473 - Install memcached on test1 [01:02:19] SPF|Cloud: memcache causes high load on mw* [01:02:41] have you found out why? [01:02:44] (When it was just left installed and running but not actively used) [01:02:51] SPF|Cloud: nope [01:02:59] then we're going to do that next time [01:03:02] This was from months ago [01:03:13] because memcached can be very useful in our environment [01:03:15] Ok [01:09:47] [02miraheze/mw-config] 07Southparkfan pushed 031 commit to 03master [+0/-0/±1] 13https://git.io/fA2XB [01:09:48] [02miraheze/mw-config] 07Southparkfan 034f68bac - Redis.php: add memcached support [01:12:20] SPF|Cloud: did you improve test1 performance? [01:12:32] Since it loads way faster then before [01:12:37] it does? :) [01:12:47] you're lucky then I guess [01:13:19] Does it load slow for you still SPF|Cloud ? [01:13:22] And yes [01:13:26] The main page [01:13:27] never been fast for me [01:14:20] It only started to become fast after your memcavhe deployment SPF|Cloud [01:14:26] *memcache [01:15:24] Thoug actually [01:15:47] Looking at your change it dosent change the object to use memcavhe [01:21:30] https://grafana.miraheze.org/d/W9MIkA7iz/miraheze-cluster?orgId=1&var-job=node&var-node=test1.miraheze.org&var-port=9100 [01:21:30] Title: [ Grafana ] - grafana.miraheze.org [05:02:17] PROBLEM - wiki.bonessdiving.club - LetsEncrypt on sslhost is WARNING: WARNING - Certificate 'wiki.bonessdiving.club' expires in 15 day(s) (Tue 25 Sep 2018 04:59:33 AM GMT +0000). [05:02:29] [02miraheze/ssl] 07MirahezeSSLBot pushed 031 commit to 03master [+0/-0/±1] 13https://git.io/fA2DA [05:02:30] [02miraheze/ssl] 07MirahezeSSLBot 03a94d3cf - Bot: Update SSL cert for wiki.bonessdiving.club [05:12:18] RECOVERY - wiki.bonessdiving.club - LetsEncrypt on sslhost is OK: OK - Certificate 'wiki.bonessdiving.club' will expire on Sat 08 Dec 2018 04:02:23 AM GMT +0000. [10:25:40] [02miraheze/ManageWiki] 07Reception123 pushed 031 commit to 03master [+0/-0/±2] 13https://git.io/fA2dx [10:25:42] [02miraheze/ManageWiki] 07Reception123 03244ff4c - header for ManageWikiDefaultPermissions [10:28:55] [02miraheze/mediawiki] 07Reception123 pushed 031 commit to 03REL1_31 [+0/-0/±3] 13https://git.io/fA2FJ [10:28:56] [02miraheze/mediawiki] 07Reception123 031283ba6 - Update ManageWiki [10:29:46] Reception123: errr [10:29:51] You reverted the changes [10:30:58] why does that always happen [10:31:01] I did git pull.. [10:31:42] Reception123: but you didn’t do git submodule update [10:31:57] That’s how I caused a wiki outage yesturday [10:31:57] oh, so you don't mean the ManageWiki changes? [10:32:13] Reception123: well you reverted the submodules :) [10:32:20] oh you mean the others [10:32:21] on it [10:32:23] (Not the actual mediawiki change) [10:32:25] Yep [10:33:11] fixed [10:33:31] [02miraheze/mediawiki] 07Reception123 pushed 031 commit to 03REL1_31 [+0/-0/±3] 13https://git.io/fA2FI [10:33:32] [02miraheze/mediawiki] 07Reception123 039df6c1e - Update WD, MA, CW [10:34:32] Ok thanks [10:35:27] :) [10:41:47] PROBLEM - wiki.svenskabriardklubben.se - LetsEncrypt on sslhost is WARNING: WARNING - Certificate 'wiki.svenskabriardklubben.se' expires in 15 day(s) (Tue 25 Sep 2018 10:38:39 AM GMT +0000). [10:41:59] [02miraheze/ssl] 07MirahezeSSLBot pushed 031 commit to 03master [+0/-0/±1] 13https://git.io/fA2FC [10:42:01] [02miraheze/ssl] 07MirahezeSSLBot 03af89774 - Bot: Update SSL cert for wiki.svenskabriardklubben.se [10:51:48] RECOVERY - wiki.svenskabriardklubben.se - LetsEncrypt on sslhost is OK: OK - Certificate 'wiki.svenskabriardklubben.se' will expire on Sat 08 Dec 2018 09:41:54 AM GMT +0000. [10:56:19] Reception123: you will need to rebuild lc :) [10:56:31] (For your i18n change) [10:57:14] I know [10:57:19] Though Puppet was taking long to run [10:57:29] !log /srv/mediawiki/w/maintenance && sudo -u www-data php rebuildLocalisationCache.php --wiki test1wiki on mw* [10:57:41] Logged the message at https://meta.miraheze.org/wiki/Tech:Server_admin_log, Master [10:58:03] Ah ok thanks [12:00:34] PROBLEM - www.splat-teams.com - LetsEncrypt on sslhost is WARNING: WARNING - Certificate 'www.splat-teams.com' expires in 15 day(s) (Tue 25 Sep 2018 11:58:12 AM GMT +0000). [12:00:45] [02miraheze/ssl] 07MirahezeSSLBot pushed 031 commit to 03master [+0/-0/±1] 13https://git.io/fA2Nh [12:00:47] [02miraheze/ssl] 07MirahezeSSLBot 0311b48d3 - Bot: Update SSL cert for www.splat-teams.com [12:11:21] PROBLEM - www.schulwiki.de - LetsEncrypt on sslhost is WARNING: WARNING - Certificate 'www.schulwiki.de' expires in 15 day(s) (Tue 25 Sep 2018 12:07:44 PM GMT +0000). [12:11:32] [02miraheze/ssl] 07MirahezeSSLBot pushed 031 commit to 03master [+0/-0/±1] 13https://git.io/fA2Aq [12:11:34] [02miraheze/ssl] 07MirahezeSSLBot 03e09d1b5 - Bot: Update SSL cert for www.schulwiki.de [12:12:33] RECOVERY - www.splat-teams.com - LetsEncrypt on sslhost is OK: OK - Certificate 'www.splat-teams.com' will expire on Sat 08 Dec 2018 11:00:40 AM GMT +0000. [12:21:21] RECOVERY - www.schulwiki.de - LetsEncrypt on sslhost is OK: OK - Certificate 'www.schulwiki.de' will expire on Sat 08 Dec 2018 11:11:27 AM GMT +0000. [12:25:14] PROBLEM - holonet.pw - LetsEncrypt on sslhost is WARNING: WARNING - Certificate 'holonet.pw' expires in 15 day(s) (Tue 25 Sep 2018 12:22:54 PM GMT +0000). [12:25:24] [02miraheze/ssl] 07MirahezeSSLBot pushed 031 commit to 03master [+0/-0/±1] 13https://git.io/fA2Au [12:25:25] [02miraheze/ssl] 07MirahezeSSLBot 03eb26045 - Bot: Update SSL cert for holonet.pw [12:31:12] RECOVERY - holonet.pw - LetsEncrypt on sslhost is OK: OK - Certificate 'holonet.pw' will expire on Sat 08 Dec 2018 11:25:18 AM GMT +0000. [13:15:12] [02miraheze/services] 07MirahezeSSLBot pushed 031 commit to 03master [+0/-0/±1] 13https://git.io/fA2xQ [13:15:14] [02miraheze/services] 07MirahezeSSLBot 03736cb3e - BOT: Updating services config for wikis [13:44:22] !log fixed duplicates in mw_permissions for test1wiki T3574 [13:44:27] Logged the message at https://meta.miraheze.org/wiki/Tech:Server_admin_log, Master [13:46:03] !log fixed duplicates in mw_permissions for metawiki T3574 [13:46:10] Logged the message at https://meta.miraheze.org/wiki/Tech:Server_admin_log, Master [14:05:22] !log fixed duplicates in mw_permissions for weatherwiki T3574 [14:05:28] Logged the message at https://meta.miraheze.org/wiki/Tech:Server_admin_log, Master [14:10:14] [02miraheze/services] 07MirahezeSSLBot pushed 031 commit to 03master [+0/-0/±1] 13https://git.io/fA2hX [14:10:15] [02miraheze/services] 07MirahezeSSLBot 0382ee3b0 - BOT: Updating services config for wikis [15:39:52] [02ManageWiki] 07paladox commented on commit 03699f68410c36eeef732c30d15a123e06fd887eba - 13https://git.io/fAavb [15:51:41] [02ManageWiki] 07The-Voidwalker opened pull request 03#21: fix logic to allow for creating a group - 13https://git.io/fAafB [15:52:18] [02ManageWiki] 07The-Voidwalker synchronize pull request 03#21: fix logic to allow for creating a group - 13https://git.io/fAafB [16:30:18] [02ManageWiki] 07paladox closed pull request 03#21: fix logic to allow for creating a group - 13https://git.io/fAafB [16:30:20] [02miraheze/ManageWiki] 07paladox pushed 031 commit to 03master [+0/-0/±1] 13https://git.io/fAaUY [16:30:21] [02miraheze/ManageWiki] 07The-Voidwalker 039bd73b7 - fix logic to allow for creating a group (#21) * fix logic to allow for creating a group * fix comment [16:31:04] [02miraheze/mediawiki] 07paladox pushed 031 commit to 03REL1_31 [+0/-0/±1] 13https://git.io/fAaU3 [16:31:06] [02miraheze/mediawiki] 07paladox 03fe97fef - Update MW [16:36:55] !log fixed duplicates in mw_permissions for wiki1776wiki T3574 [16:37:00] Logged the message at https://meta.miraheze.org/wiki/Tech:Server_admin_log, Master [16:39:03] PROBLEM - test1 Puppet on test1 is CRITICAL: CRITICAL: Puppet has 1 failures. Last run 3 minutes ago with 1 failures. Failed resources (up to 3 shown): Exec[git_pull_MediaWiki core] [16:41:37] So, how does a current wiki creator be awarded the wiki manager role. Do I just inform system administrators of my want to be included in this or? [16:42:34] SPF|Cloud ^^ [16:42:47] I guess existing wiki creators ask a steward? [16:42:52] (or maybe a sysop?) [16:43:19] !log fixed duplicates in mw_permissions for testwiki T3574 [16:43:24] Logged the message at https://meta.miraheze.org/wiki/Tech:Server_admin_log, Master [16:43:59] "Current wiki creators (as of 15:26, 9 September 2018 (UTC)) may decide to stay in one or both groups." [16:44:06] "System administrators (see Staff, "Operations" or "MediaWiki System Administrator") may give users (which includes other system administrators or themselves as well) these rights without the need for community appointment." [16:44:19] So i guess we can do it [16:44:27] wish it would've been community only, but yeah [16:44:42] a system administrator can do it for you [16:47:45] That would be great, I'd love to help out. [16:48:25] I mean, it would help if we created the group :P [16:48:59] lol [16:54:12] group exists now, so yay! [17:00:30] [02miraheze/ManageWiki] 07paladox pushed 031 commit to 03paladox-patch-1 [+0/-0/±1] 13https://git.io/fAaT2 [17:00:31] [02miraheze/ManageWiki] 07paladox 0335d3f83 - Fix linked url to ListUsers in generated log [17:00:33] [02ManageWiki] 07paladox created branch 03paladox-patch-1 - 13https://git.io/vpSns [17:00:34] [02ManageWiki] 07paladox opened pull request 03#22: Fix linked url to ListUsers in generated log - 13https://git.io/fAaTa [17:05:48] [02ManageWiki] 07paladox closed pull request 03#22: Fix linked url to ListUsers in generated log - 13https://git.io/fAaTa [17:05:49] [02miraheze/ManageWiki] 07paladox deleted branch 03paladox-patch-1 [17:05:51] [02ManageWiki] 07paladox deleted branch 03paladox-patch-1 - 13https://git.io/vpSns [17:15:12] [02miraheze/services] 07MirahezeSSLBot pushed 031 commit to 03master [+0/-0/±1] 13https://git.io/fAakT [17:15:13] [02miraheze/services] 07MirahezeSSLBot 033ac5b7e - BOT: Updating services config for wikis [17:37:40] !log sudo -u www-data foreachwikiindblist /srv/mediawiki/dblist/all.dblist /srv/mediawiki/w/maintenance/runJobs.php on all mw wikis and test1wiki (huge queue) [17:37:45] These jobs are very annoying [17:37:45] Logged the message at https://meta.miraheze.org/wiki/Tech:Server_admin_log, Master [17:38:32] I wonder what created all of them this time [17:39:29] Voidwalker: me too [17:39:39] 82,000 jobs is really exagerrated [17:39:50] Voidwalker: of course our friend LocalGlobalUserPageCacheUpdateJob can be seen very often again [17:42:30] https://meta.miraheze.org/w/index.php?title=User:Robertinventor&action=history [17:42:31] Title: [ Revision history of "User:Robertinventor" - Miraheze Meta ] - meta.miraheze.org [17:54:10] [02miraheze/mw-config] 07paladox pushed 031 commit to 03master [+0/-0/±1] 13https://git.io/fAakb [17:54:12] [02miraheze/mw-config] 07paladox 03b6ce458 - Remove if check [18:07:21] [02miraheze/ManageWiki] 07Southparkfan pushed 031 commit to 03master [+0/-0/±3] 13https://git.io/fAaIO [18:07:22] [02miraheze/ManageWiki] 07Southparkfan 039d9a485 - Do not retrieve permissions from DB on every page hit A serialized array of wgAddGroups, wgGroupPermissions and wgRemoveGroups will be stored in memcached if possible. [18:08:30] [02miraheze/ManageWiki] 07Southparkfan pushed 031 commit to 03master [+0/-0/±1] 13https://git.io/fAaIs [18:08:32] [02miraheze/ManageWiki] 07Southparkfan 03dd2b458 - Remove some debug code :) [18:09:43] Voidwalker: paladox You've got to be kidding me! [18:09:47] 90k+ jobs now [18:09:53] LOL LOL [18:10:00] How are they getting larger instead of smaller? [18:10:13] Because maybe someone edited there user page? [18:10:30] paladox: checked RC and nope [18:10:41] ok [18:10:45] then im not sure [18:11:04] JOBQUEUE CRITICAL - job queue greater than 300 jobs. Current queue: 91327 [18:11:07] yeah [18:11:12] Hmm.. how would I go about creating a new user group (“extendedconfirmed”) that users would be automatically promoted to by the software once certain conditions are met, but that group is NOT implicit like autoconfirmed [18:11:16] MacFan4000: yep [18:11:37] AmandaCatherine: that can only be done with LocalSettings.php [18:11:53] Reception123: I know, but how and where? [18:12:21] AmandaCatherine: you can use ctrl+f to view existing conditions for extendedconfirmed groups [18:12:25] It's something with APCOND I believe [18:12:28] so you can search that [18:13:12] Reception123 are you seeing a lot of any peticular job? [18:13:14] [02miraheze/mediawiki] 07paladox pushed 031 commit to 03REL1_31 [+0/-0/±1] 13https://git.io/fAaI0 [18:13:15] [02miraheze/mediawiki] 07paladox 03ee22336 - Update MW [18:13:53] MacFan4000: mostly GlobalUserpage yeah [18:14:14] and then other usual ones like htmlcacheupdate, refreshlinks, etc. [18:14:40] Reception123: so I’d assume that “APCOND_EDITCOUNT” is the number of total edits, and “APCOND_AGE” is the age of the user account since creation? [18:14:50] Yes [18:15:19] Does “APCOND_EDITCOUNT” include deleted edits, and does “APCOND_AGE” refer to the age of the global account or the age of the local account? [18:15:47] yes and local I believe [18:16:01] Ok [18:17:05] So to create an extendedconfirmed group that would be automatically added after 30 days and 100 edits, it would be APCOND_EDITCOUNT, 100 and APCOND_AGE, 30 [18:17:08] ? [18:17:21] yes [18:18:24] Why are all of the other $wgAutopromote settings using “# * 86400” as their APCOND_AGE [18:18:42] because APCOND_AGE is in seconds iirc [18:19:03] So what does that code do? [18:19:18] Multiply # of days by 86400 seconds? [18:19:23] convers days to seconds [18:19:28] converts [18:19:42] 86400 is 24 hours I believe [18:19:54] So for 30 days, it would be 30 * 86400 [18:21:58] [02mw-config] 07Amanda-Catherine opened pull request 03#2441: Add extendedconfirmed user group for weatherwiki - 13https://git.io/fAaIy [18:25:18] AmandaCathrine: I comment on your Pull request [18:25:38] Ok [18:26:35] [02mw-config] 07Amanda-Catherine synchronize pull request 03#2441: Add extendedconfirmed user group for weatherwiki - 13https://git.io/fAaIy [18:27:53] [02mw-config] 07MacFan4000 closed pull request 03#2441: Add extendedconfirmed user group for weatherwiki - 13https://git.io/fAaIy [18:27:55] [02miraheze/mw-config] 07MacFan4000 pushed 031 commit to 03master [+0/-0/±1] 13https://git.io/fAaIp [18:27:56] [02miraheze/mw-config] 07Amanda-Catherine 03e14afed - Add extendedconfirmed user group for weatherwiki (#2441) * Add extendedconfirmed user group for weatherwiki * Fix syntax [18:29:05] !log clear 63k htmlCacheUpdate jobs for crappygameswiki; deleted all redis keys matching "crappygameswiki:jobqueue:htmlCacheUpdate:*" [18:29:10] Logged the message at https://meta.miraheze.org/wiki/Tech:Server_admin_log, Master [18:29:32] One more PR incoming MacFan4000 [18:29:59] [02mw-config] 07Amanda-Catherine opened pull request 03#2442: Restrict editing of sensitive namespaces on weatherwiki - 13https://git.io/fAaLe [18:30:41] [02mw-config] 07MacFan4000 closed pull request 03#2442: Restrict editing of sensitive namespaces on weatherwiki - 13https://git.io/fAaLe [18:30:43] [02miraheze/mw-config] 07MacFan4000 pushed 031 commit to 03master [+0/-0/±1] 13https://git.io/fAaLf [18:30:44] [02miraheze/mw-config] 07Amanda-Catherine 03da1cbcd - Restrict editing of sensitive namespaces on weatherwiki (#2442) [18:31:08] Oh crap that removed the $wgAutopromote somehow [18:31:11] PHP Warning: Use of undefined constant NS_MODULE - assumed 'NS_MODULE' (this will throw an Error in a future version of PHP) in /srv/mediawiki/config/LocalSettings.php on line 3893 [18:31:38] [02mw-config] 07Amanda-Catherine opened pull request 03#2443: Revert "Restrict editing of sensitive namespaces on weatherwiki" - 13https://git.io/fAaLU [18:31:55] * AmandaCatherine slaps herself around with a large trout [18:31:57] [02mw-config] 07MacFan4000 closed pull request 03#2443: Revert "Restrict editing of sensitive namespaces on weatherwiki" - 13https://git.io/fAaLU [18:31:59] [02miraheze/mw-config] 07MacFan4000 pushed 031 commit to 03master [+0/-0/±1] 13https://git.io/fAaLT [18:32:00] [02miraheze/mw-config] 07Amanda-Catherine 037f2376a - Revert "Restrict editing of sensitive namespaces on weatherwiki (#2442)" (#2443) This reverts commit da1cbcd4f0c707be3123f414033259092cf37307. [18:32:19] Let’s try that again [18:33:58] People sure enjoy slapping [18:34:06] paladox loves slapping his fellow sysadmins.. [18:34:11] AmandaCatherine slaps herself.. [18:34:16] lol Reception123 [18:34:19] * paladox slaps Reception123 around a bit with a large trout [18:34:21] * paladox slaps re around a bit with a large trout [18:34:25] * paladox slaps Reception123 around a bit with a large trout [18:34:39] * MacFan4000 slaps paladox with a trout [18:34:41] paladox: make sure Sigyn doesn't kick you for spam! [18:34:42] !log deleted another 5k htmlCacheUpdate jobs for microtonalwiki [18:34:42] lol [18:34:45] Reception123: I slap myself because I did something stupid that I don’t even understand [18:34:46] and I don't need to be slapped 3 times [18:34:47] Logged the message at https://meta.miraheze.org/wiki/Tech:Server_admin_log, Master [18:34:59] SPF|Cloud: so can htmlCacheUpdate jobs be deleted if they're causing trouble? [18:35:38] yes. ideally we don't but this is way too excessive and seems very unusual [18:36:44] about 700 htmlCacheUpdate left globally, not going to delete those [18:36:51] ok [18:36:55] Im wondering why mw3 has such a high load [18:36:56] https://grafana.miraheze.org/d/W9MIkA7iz/miraheze-cluster?orgId=1&var-job=node&var-node=mw3.miraheze.org&var-port=9100 [18:36:57] Title: [ Grafana ] - grafana.miraheze.org [18:36:59] SPF|Cloud we should try and reduce mw3 load [18:37:01] SPF|Cloud: what exactly happens if those jobs are deleted? [18:37:08] paladox: it's jobs... [18:37:13] no jobs = no work for the jobrunners [18:37:17] oh [18:37:32] when the jobs go down the load will too [18:37:37] [02mw-config] 07Amanda-Catherine opened pull request 03#2444: Redo #2442 - 13https://git.io/fAaLG [18:37:41] SPF|Cloud: yeah, but what does it affect deleting those for the wiki? [18:37:48] if let's say there's another excessive amount [18:38:11] well if you remove the jobs from the jobqueue, they don't exist anymore thus the jobrunners will stop doing them [18:38:14] very simple :) [18:39:10] [02mw-config] 07MacFan4000 closed pull request 03#2444: Redo #2442 - 13https://git.io/fAaLG [18:39:12] [02miraheze/mw-config] 07MacFan4000 pushed 031 commit to 03master [+0/-0/±1] 13https://git.io/fAaLl [18:39:13] [02miraheze/mw-config] 07Amanda-Catherine 03edcaa1e - Redo #2442 (#2444) Let’s try this again [18:47:36] !log killed runJobs.php on mw2 [18:47:41] Logged the message at https://meta.miraheze.org/wiki/Tech:Server_admin_log, Master [18:49:14] PROBLEM - mw3 JobChron Service on mw3 is CRITICAL: PROCS CRITICAL: 0 processes with args 'redisJobChronService' [18:49:26] PROBLEM - mw3 JobRunner Service on mw3 is CRITICAL: PROCS CRITICAL: 0 processes with args 'redisJobRunnerService' [18:49:36] uh [18:49:54] uhmm well now looks like we've got no jobs running [18:49:57] SPF|Cloud: did you terminate that? [18:50:08] no? that was mw2 [18:50:46] SPF|Cloud: oh, then why does it look like mw3 jobrunner is down too? [18:51:00] !log restarted jobrunner on mw3 + kill runJobs.php process [18:51:08] Logged the message at https://meta.miraheze.org/wiki/Tech:Server_admin_log, Master [18:51:14] RECOVERY - mw3 JobChron Service on mw3 is OK: PROCS OK: 1 process with args 'redisJobChronService' [18:51:26] RECOVERY - mw3 JobRunner Service on mw3 is OK: PROCS OK: 1 process with args 'redisJobRunnerService' [18:56:25] !log mw2: /usr/local/bin/foreachwikiindblist /srv/mediawiki/dblist/all.dblist /srv/mediawiki/w/maintenance/runJobs.php --type=LocalGlobalUserPageCacheUpdateJob [18:56:32] Logged the message at https://meta.miraheze.org/wiki/Tech:Server_admin_log, Master [18:58:44] SPF|Cloud: Oh, I didn't know you can run for specific types [18:58:47] That's very good to know [19:03:53] !log deleted ALL LocalGlobalUserPageCacheUpdateJob and htmlCacheUpdate jobs for ALL wikis [19:04:03] Reception123 MacFan4000 the new extendedconfirmed group on my wiki is being treated as an implicit group [19:04:07] Logged the message at https://meta.miraheze.org/wiki/Tech:Server_admin_log, Master [19:04:12] It's.. not worth it [19:04:35] wgAutopromote does that [19:04:48] But can it still be manually added and removed? [19:05:20] MacFan4000 ^ [19:05:36] AmandaCatherine: it will have to be switched from using wgAutopromote to wgAutopromoteOnce [19:05:52] MacFan4000: ok [19:10:19] [02mw-config] 07Amanda-Catherine opened pull request 03#2445: Fix weatherwiki extendedconfirmed group - 13https://git.io/fAat9 [19:16:26] [02mw-config] 07Amanda-Catherine synchronize pull request 03#2445: Fix weatherwiki extendedconfirmed group - 13https://git.io/fAat9 [19:17:35] [02miraheze/puppet] 07paladox pushed 031 commit to 03master [+0/-0/±1] 13https://git.io/fAaqs [19:17:37] [02miraheze/puppet] 07paladox 03b1b9a55 - Install memcached on mw* [19:17:42] [02mw-config] 07MacFan4000 closed pull request 03#2445: Fix weatherwiki extendedconfirmed group - 13https://git.io/fAat9 [19:17:43] [02miraheze/mw-config] 07MacFan4000 pushed 031 commit to 03master [+0/-0/±1] 13https://git.io/fAaqG [19:17:45] [02miraheze/mw-config] 07Amanda-Catherine 03af0b1c0 - Fix weatherwiki extendedconfirmed group (#2445) * Fix weatherwiki extendedconfirmed group * Update LocalSettings.php [19:18:34] Hmm, it was nice when PR comments were reported on IRC [19:20:04] PR’s in mw-config were never reported [19:20:08] MacFan4000: it was always only for Puppet [19:20:09] Only those in other repos were [19:20:15] MacFan4000: though you can enable them if you'd like :) [19:20:49] Reception123: the hook is global, and so only owners can modify it [19:21:08] ook [19:21:10] *ok [19:21:28] now since mw-config PRs are more rare and usually done by experienced volunteers it can be enabled [19:21:44] [02miraheze/mw-config] 07MacFan4000 pushed 031 commit to 03master [+0/-0/±1] 13https://git.io/fAaqG [19:21:45] [02miraheze/mw-config] 07Amanda-Catherine 03af0b1c0 - Fix weatherwiki extendedconfirmed group (#2445) * Fix weatherwiki extendedconfirmed group * Update LocalSettings.php [19:22:00] Did you just merge something twice MacFan4000? [19:22:07] No [19:22:22] [02GitHub] Favor focus over features. [19:22:32] Uhh.. what ^ ? [19:22:33] uh who sent that one [19:22:41] * AmandaCatherine is confused [19:22:43] double notifications was me but that last one wasen't [19:23:05] heh [19:23:06] Pull request diff comment created, edited, or deleted. [19:23:11] it looks like it's checked [19:23:15] [02mw-config] 07MacFan4000 commented on pull request 03#2445: Fix weatherwiki extendedconfirmed group - 13https://git.io/fAaqa [19:23:16] [02mw-config] 07MacFan4000 commented on pull request 03#2445: Fix weatherwiki extendedconfirmed group - 13https://git.io/fAaqa [19:23:35] Why is it now reporting comments for a merged PR? [19:23:36] uh, i enabled it globally [19:23:37] so lol [19:23:39] ah no, it's considered an "issue comment" [19:23:42] oh ok paladox did it [19:23:52] but MacFan4000 enabled it on there too [19:23:56] so it's double reporting now [19:24:09] Shouldn’t it take effect for the next PR? [19:24:17] Not start reporting on merged/closed PRs before it was enabled? [19:24:17] yeah [19:24:22] I'd think so [19:24:30] Nope, not if you click resubmit [19:24:35] on the notification that was sent [19:24:36] I think we should check the boxes for pull request comments, pull request review comments, and pull requests [19:24:41] I commented as a test [19:25:30] sure [19:26:07] Oh and pull request reviews [19:26:42] [02mw-config] 07paladox commented on pull request 03#2445: Fix weatherwiki extendedconfirmed group - 13https://git.io/fAaqX [19:26:57] That’s better [19:27:31] [02mw-config] 07paladox deleted a comment on pull request 03#2445: Fix weatherwiki extendedconfirmed group - 13https://git.io/fAaqX [19:27:46] [02mw-config] 07MacFan4000 deleted a comment on pull request 03#2445: Fix weatherwiki extendedconfirmed group - 13https://git.io/fAaqa [19:27:56] nope [19:28:00] [02mw-config] 07MacFan4000 reviewed pull request 03#2445 commit - 13https://git.io/fAaqH [19:28:01] oh nvm it's not double [19:28:04] it's both paladox and MacFan4000 [19:29:15] [02miraheze/MirahezeMagic] 07Reception123 pushed 031 commit to 03master [+0/-0/±1] 13https://git.io/fAaq5 [19:29:16] [02miraheze/MirahezeMagic] 07Reception123 03509c40d - add wikimanager [19:30:02] [02miraheze/MirahezeMagic] 07Reception123 pushed 031 commit to 03master [+0/-0/±1] 13https://git.io/fAaqA [19:30:04] [02miraheze/MirahezeMagic] 07Reception123 03a4b6938 - fix [19:30:43] Uhh.. why is the edit filter manager group still existing on my wiki even though I deleted it in MWP by removing all rights from it [19:30:46] [02mw-config] 07MacFan4000 reviewed pull request 03#2445 commit - 13https://git.io/fAaqH [19:30:55] AmandaCatherine: Pretty sure there's an error with that [19:30:56] https://i.imgur.com/rWgZxbL.jpg [19:31:01] It's a bug [19:31:12] JohnLewis said that the way to delete a group was remove all permissions in MWP [19:31:31] yeah, we're trying to fix it, but it's not working right now [19:31:35] I wonder why things like https://github.com/miraheze/MirahezeMagic/compare/7aa291229d57...509c40d91cc6#diff-bcc35b4a55b540cafff0b34f3c38605dL60 aren’t defined in the extensions that create those userrights [19:31:35] Title: [ Comparing 7aa291229d57...509c40d91cc6 · miraheze/MirahezeMagic · GitHub ] - github.com [19:31:38] JohnLewis: ^ [19:31:58] MacFan4000: good point [19:32:01] they probably should be IMO [19:32:09] Since that's not Miraheze specific is it? [19:32:31] @miraheze miraheze deleted a comment from MacFan4000 a minute ago [19:32:40] Ok, now the changes I made to group just got reverted [19:32:46] How is that even possible [19:32:53] I removed all permission from the group and now they mysteriously reappeared [19:33:20] MacFan4000 i removed your inline test comment [19:33:29] Oh nvm [19:33:30] Isn’t cache local [19:33:32] JohnLewis: 2018-09-08 - 21:37:19 tell JohnLewis please investigate https://phabricator.miraheze.org/T3574 ASAP [19:33:35] ? [19:33:43] Why did it say that miraheze did it [19:33:50] paladox: [19:33:52] Already taken care of ZppixBot [19:33:59] because im in the miraheze org on github [19:34:09] so it thinks i took action on behave of it [19:34:15] these are pure guesses [19:34:45] Ok, so now the group I removed in MWP is gone from Special:UserRights but it still shows up (albeit empty) in ListGroupRights [19:34:47] If cache is local, the cache will be deleted locally [19:35:10] meaninh every mw* server will serve different userrights [19:35:13] I suppose we should remove the unneeded webhooks from repos? [19:35:49] JohnLewis: is there something else that I have to do to delete a user group from my wiki besides removing all permissions from it in MWP [19:36:28] No, if it’s empty it’s should go but Void said he broke it [19:36:57] in order to be able to create new groups [19:37:00] “You’re doing bad work, Voidwalker!” [19:37:00] JohnLewis well it was either have create group as broken or delete groups, we choice to break delete groups instead :P [19:37:19] AmandaCatherine no he is doing good work, see message to john above. [19:37:38] But he’s doing bad work to break something in order to do something else [19:37:41] tbh though, the bug makes no sense to me [19:37:48] You can’t rob Peter to pay Paul, you need to do both [19:37:59] huh? [19:38:07] It’s an analogy [19:38:15] You can’t break one thing in order to add or fix another thing [19:38:25] You need to add or fix the other thing while maintaining the first thing [19:38:57] oh [19:40:23] Ok now the main content namespace is protected! [19:40:28] What the heck? [19:40:49] No typos here that I can see https://github.com/miraheze/mw-config/blob/master/LocalSettings.php#L3889 [19:40:50] Title: [ mw-config/LocalSettings.php at master · miraheze/mw-config · GitHub ] - github.com [19:40:54] Voidwalker: $countexisting != $newchanges will alwaya never true [19:41:08] *always be true [19:42:01] JohnLewis, but that was your code [19:42:12] With the (Main) namespace mysteriously being protected, now my wiki is broken [19:42:22] lol [19:42:25] On top of the MWP removal bug and another bug that I haven’t mentioned yet [19:43:30] JohnLewis: I didn’t protect the main namespace here https://github.com/miraheze/mw-config/blob/master/LocalSettings.php#L3889 but for some reason the main namespace is protected under the “edit-restrictednamespace” right [19:43:31] Title: [ mw-config/LocalSettings.php at master · miraheze/mw-config · GitHub ] - github.com [19:43:35] and besides it's $countExisting != $countRemoves [19:43:35] Well, no code is perfect [19:43:48] Every code needs improvement [19:43:54] and in this case of course some fixes must be made [19:43:57] JohnLewis new wikis created get added to mw_permissions right? [19:43:59] What was the issue with creations? [19:44:04] even if we switched mwp off for wikis. [19:44:51] [02miraheze/mw-config] 07paladox pushed 031 commit to 03master [+0/-0/±3] 13https://git.io/fAaml [19:44:52] [02miraheze/mw-config] 07paladox 039bd794d - Revert "Revert "convert GroupPermissions to ManageWiki"" This reverts commit e08a701df442fe3449d0679c2499c48faf550311. [19:44:56] Also module namespace isn’t protected like it should be [19:44:56] MWP redeployed now [19:45:36] It seems like that instead of protecting the module namespace https://github.com/miraheze/mw-config/blob/master/LocalSettings.php#L3896 it protected the main namespace instead [19:45:37] Title: [ mw-config/LocalSettings.php at master · miraheze/mw-config · GitHub ] - github.com [19:45:53] That’s a fatal bug right there, since now nobody can edit the wiki [19:46:44] Paladox: no? [19:46:52] oh [19:46:54] ok [19:46:59] think I if’d it [19:46:59] JohnLewis i just re deployed MWP [19:47:22] not sure if that was the best idea judging from SPFs last message :P [19:47:30] Caching is broke though [19:47:54] if I understand the classes, it updates cache locally only [19:48:00] Yeah youre right [19:48:01] Voidwalker oh meh just saw that. [19:48:07] let me revert again [19:48:17] * AmandaCatherine slaps paladox around with a large trout [19:48:25]