[10:30:41] (03CR) 10Thiemo Kreuz (WMDE): [C: 04-1] "I would have merged patch set 3. Patch set 4 introduces new messages. I'm not sure if this is worth it. Note this extension is effectively" (031 comment) [extensions/ArticleFeedbackv5] - 10https://gerrit.wikimedia.org/r/483920 (owner: 10Jack Phoenix) [10:51:50] (03CR) 10Thiemo Kreuz (WMDE): Moved some files in includes/ directory (031 comment) [extensions/ArticleFeedbackv5] - 10https://gerrit.wikimedia.org/r/495254 (owner: 10Zoranzoki21) [17:09:24] (03PS5) 10Jack Phoenix: Replace dieUsage()/dieUsageMsg() with dieWithError() in the API modules [extensions/ArticleFeedbackv5] - 10https://gerrit.wikimedia.org/r/483920 [17:18:20] (03CR) 10Jack Phoenix: "@Thiemo: Thanks for the CR again, nice catch!" [extensions/ArticleFeedbackv5] - 10https://gerrit.wikimedia.org/r/483920 (owner: 10Jack Phoenix) [17:54:46] (03PS1) 10Jack Phoenix: Job::insert() no longer exists in core, no point in overriding it and/or calling parent::insert() in a subclass... [extensions/ArticleFeedbackv5] - 10https://gerrit.wikimedia.org/r/495725 (https://phabricator.wikimedia.org/T179624) [18:12:10] (03CR) 10Aaron Schulz: [C: 03+2] Job::insert() no longer exists in core, no point in overriding it and/or calling parent::insert() in a subclass... [extensions/ArticleFeedbackv5] - 10https://gerrit.wikimedia.org/r/495725 (https://phabricator.wikimedia.org/T179624) (owner: 10Jack Phoenix) [18:31:06] (03Merged) 10jenkins-bot: Job::insert() no longer exists in core, no point in overriding it and/or calling parent::insert() in a subclass... [extensions/ArticleFeedbackv5] - 10https://gerrit.wikimedia.org/r/495725 (https://phabricator.wikimedia.org/T179624) (owner: 10Jack Phoenix) [19:30:56] (03CR) 10Thiemo Kreuz (WMDE): [C: 03+1] "> […] Brickipedia, the English-language LEGO wiki hosted by ShoutWiki, is still using it and just like in 2016, I'm not aware of any plans" [extensions/ArticleFeedbackv5] - 10https://gerrit.wikimedia.org/r/483920 (owner: 10Jack Phoenix) [20:00:38] pinged. [21:49:05] (03PS1) 10Jack Phoenix: Cleanup to (some) hooks [extensions/ArticleFeedbackv5] - 10https://gerrit.wikimedia.org/r/495810