[15:01:05] <ashley>	 afternoon SamanthaNguyen, how's stuff? :)
[15:02:49] <SamanthaNguyen>	 hey ashley o/ i'm doing alright, i woke up about 3 hours ago I think :P
[15:03:04] <ashley>	 hehe, nice :P
[15:03:28] <SamanthaNguyen>	 also just pushed out a ticket :P how are ya doing? :P
[15:03:37] <ashley>	 I just published some of ShoutWiki's secret sauce upstream: [17:02:37]	<wikibugs>	(PS1) Jack Phoenix: Publishing ShoutWiki's version (v. 3.1-SW) of MultiUpload for MW 1.28+ [extensions/MultiUpload] - https://gerrit.wikimedia.org/r/334788
[15:03:53] <ashley>	 (also I wanna state for the record just how much I hate MultiUpload...it's so awful)
[15:04:10] <SamanthaNguyen>	 sweet! hopefully this makes MultiUpload a lot more stable
[15:05:19] <SamanthaNguyen>	 I actually pushed out a patch for removing the PHP entry point which is at https://gerrit.wikimedia.org/r/#/c/334481/1 a few days before, should I abandon it?
[15:05:47] <ashley>	 sure, it's already included in that huge patchset of mine
[15:05:58] <ashley>	 and yes, this provenly makes MultiUpload at least *usable* under MW 1.28+ :P
[15:07:01] <ashley>	 stableness can really be achived only if the current codebase is (once again!) scrapped and rewritten from scratch in collaboration with WMF devs (which probably ain't gonna happen anytime soon 'cause the WMF has UploadWizard, which, despite also being an awful piece of junk (notice a trend here?) provides similar functionality which is "good enough" for their needs)
[15:08:29] <SamanthaNguyen>	 hmm, I see
[15:08:39] <SamanthaNguyen>	 now you just need someone to review the patch :P
[15:10:40] <ashley>	 that should be taken care of soon ;-)
[15:10:56] <SamanthaNguyen>	 hmm lol there were two files specifically for 1.21.3, i didn't notice that before 
[15:11:01] <SamanthaNguyen>	 nice :P
[15:11:58] <ashley>	 Lee Worden (who rewrote it a couple years ago) was quite keen on backwards compat with literally ancient versions of MW
[15:12:22] <ashley>	 but he hasn't really been around ever since that, so...let's just say I don't care too much about his opinion when it comes to now-EOL'd versions of MW, sorry >.>
[15:14:27] <ashley>	 re: your https://phabricator.wikimedia.org/T156551 , so the JS has pretty much been ported over to jQuery from YUI as-is, or at least I've tried to avoid making any huge changes. the original code used new YAHOO.widget.Effects.Appear(el, { duration:2.0 }); and I *think* the current code was at least pretty close to that, but I'll admit I didn't test it out and before that the last time I...
[15:14:28] <ashley>	 ...used ImageRating (on Wikia) was like literally in 2007 or so, so yeah. anyway, patches welcome :)
[15:15:58] <SamanthaNguyen>	 I'll submit a patch, don't worry :-)
[15:16:44] <SamanthaNguyen>	 oh sweet, just noticed that MatmaRex C+2'd your patch and got it merged :P
[15:19:22] <ashley>	 awesome :D
[15:22:09] <SamanthaNguyen>	 oh and you probably already saw, but I just submitted https://phabricator.wikimedia.org/T156553 and https://phabricator.wikimedia.org/T156552
[15:23:35] <SamanthaNguyen>	 now I'll just open illustrator and modify one of the current icons to make it half-filled, which will be easy :P
[15:25:29] <ashley>	 cool :) that should make the stars look better on mobile since they're svgs instead of pngs or other non-scalable graphics
[15:28:15] <SamanthaNguyen>	 yep! vectors are quite useful, and not only that, the current icons are currently a bit..out-of-date, i must say :P
[15:28:56] <SamanthaNguyen>	 oh that reminds me, I submitted a patch earlier yesterday for ImageRating - https://gerrit.wikimedia.org/r/#/c/334746/
[15:30:15] <ashley>	 thanks, merged
[15:30:35] <SamanthaNguyen>	 sweet
[15:34:18] <SamanthaNguyen>	 oh i also saw https://gerrit.wikimedia.org/r/#/c/334786/ and https://gerrit.wikimedia.org/r/#/c/334784/1 (2 patches to UserStatus by other people)
[15:42:27] <SamanthaNguyen>	 looks like Umheirrender also pushed some patches to a ton of other extensions (mostly social tools and shoutwiki stuff) https://gerrit.wikimedia.org/r/#/q/topic:description+(status:open+OR+status:merged) just in case you didn't see it :P
[15:43:21] <ashley>	 I'm doing my best to not to see those >.>
[15:43:43] <SamanthaNguyen>	 okay :P
[15:44:13] <ashley>	 I guess I'll have to approve those or else someone else does it anyway
[15:44:23] <ashley>	 but IMO descriptionmsg was and is nothing but a mistake, period
[15:49:22] <SamanthaNguyen>	 that reminds me, i saw in some task that the description field is going to be deprecated
[15:50:14] <SamanthaNguyen>	 I'm not sure where the exact ticket, but I recall seeing some documentation tickets tagged with Developer Wishlist 2017 in my notifications, let me look through (just to check, I might've misread or maybe my memory is crap)
[15:51:13] <ashley>	 yeah, figured as much
[15:54:41] <SamanthaNguyen>	 well, my memory is sure that it was in https://phabricator.wikimedia.org/T155029, guess not though 
[16:00:36] <SamanthaNguyen>	 oh btw it looked like there was a leftover file in MultiUpload, so I just submitted a patch too :P https://gerrit.wikimedia.org/r/#/c/334790/
[16:05:30] <ashley>	 lgtm (but I didn't test)
[16:08:41] <SamanthaNguyen>	 :D
[16:08:55] <SamanthaNguyen>	 brb, gonna be back in 10-15 mins-ish (maybe 20)
[16:10:33] <ashley>	 kk
[16:26:20] <SamanthaNguyen>	 back o/
[16:26:46] <SamanthaNguyen>	 time to push out some patches for cleaning the CSS in those social tools; they're a little messy :P
[16:36:51] <SamanthaNguyen>	 ashley: https://phabricator.wikimedia.org/T156555
[16:41:10] <ashley>	 good catch, although definitely not trivial to fix
[16:48:19] <ashley>	 MW has a category API: https://www.mediawiki.org/wiki/API:Categories but I don't think it's quite working the way I'd like it to: http://social-tools.wmflabs.org/w/api.php?action=query&titles=File:CuteCat.jpg&prop=categories
[16:49:54] <SamanthaNguyen>	 aw
[16:50:44] <SamanthaNguyen>	 maybe it's because the categories don't exist yet? they're still red links
[16:53:05] <ashley>	 yea, but we need something that doesn't care about red/bluelink status :-/
[16:53:47] <SamanthaNguyen>	 :-( 
[16:56:37] <ashley>	 we already implement our own API module in ImageRating for adding the category/-ies, so we're not exactly constrained by whatever core has (or hasn't), but if we can avoid code duplication, that'd be great
[17:05:26] <SamanthaNguyen>	 https://www.mediawiki.org/wiki/API:Categoryinfo ?
[17:05:33] <SamanthaNguyen>	 It checks whether or not a category exists
[17:21:29] <SamanthaNguyen>	 ashley: tada! https://gerrit.wikimedia.org/r/334792 https://gerrit.wikimedia.org/r/334794 https://gerrit.wikimedia.org/r/#/c/334796/
[17:23:50] <ashley>	 +2'd the first; can't +2 the second, you'll have to find someone else for that; would prefer not +2'ing the last one because it's already included in https://gerrit.wikimedia.org/r/#/c/332045 (but if you wanna test that out, please feel free to :-) the only reason I haven't merged it is because it's untested and I haven't found anyone qualified to do CR on it)
[17:25:58] <SamanthaNguyen>	 ah alright :-) just added Daniel Friesen to the 2nd patch (tag cloud extension)
[17:26:06] <SamanthaNguyen>	 * as a reviewer
[17:28:11] <ashley>	 heh, yeah, good luck getting a review out of him, he hasn't been doing MW stuff actively for years (at least in public, that is)
[17:31:41] <SamanthaNguyen>	 really? according to https://gerrit.wikimedia.org/r/#/q/owner:%22Daniel+Friesen%22+status:open, he last updated a patch last 26 2016 (5 weeks ago, but still better than "years"? :P)
[17:34:54] <SamanthaNguyen>	 well, it was only one patch that he last updated, so i guess years is accurate P
[17:35:10] <ashley>	 yes, really. if you look at the patchset, his last change to it was in 2013 (June 8th), but another person updated it in December 2016
[17:36:42] <ashley>	 https://www.mediawiki.org/wiki/Special:Contributions/Dantman -- he edited a bit in 2016 but I think it's safe to say he isn't actively involved with MediaWiki these days
[18:20:58] <SamanthaNguyen>	 ah
[18:21:03] <SamanthaNguyen>	 brb, gonna write a ticket for Comments extension
[19:18:40] <SamanthaNguyen>	 sorry for taking so long..it's quite a complicated ticket
[19:19:13] <SamanthaNguyen>	 it's basically tackling a history interface for comments
[20:36:05] <SamanthaNguyen>	 ashley: not a Comments ticket here, but a general social tools ticket: https://phabricator.wikimedia.org/T156561
[21:46:20] <ashley>	 brb rebooting
[21:49:49] <SamanthaNguyen>	 okeydokes
[22:44:39] <ashley>	 hey seaside98, how's stuff? :)
[22:44:48] <ashley>	 SamanthaNguyen: aaaaaand I'm baaaaaaack :P
[22:45:18] <SamanthaNguyen>	 hey :P o/ 
[22:45:19] <seaside98>	 Hey! good as ever. How are you?
[22:47:47] <SamanthaNguyen>	 ashley: Just ran `git grep clearfix` through the extensions, got more results this time: https://phabricator.wikimedia.org/T156561#2979852 So far just extensions tested out so far, which returned results in FanBoxes, LinkFilter, SocialProfile
[22:49:32] <ashley>	 yea, clearfix is supposed to be used, cleared class shoulda died a long time ago but guess what, it's a zombie and still lives on in some skins >.<
[22:49:57] <ashley>	 I'm okay, working on improving stuff with Sam :P it's not always so easy
[22:54:08] <SamanthaNguyen>	 i know it's supposed to be used, but i'm working on patches so hacky stuff like clears, floats, absolute positioning won't be needed :P
[22:54:26] <SamanthaNguyen>	 becuase usually clear is only needed if you use hacky floats and absolute positioning (which shouldn't be used)
[22:56:11] <SamanthaNguyen>	 e.g you don't need to make two things float to the left so they're on the same line when you can just make both things inline blocks
[22:57:05] <SamanthaNguyen>	 and plus, when they're inline blocks they're still considered to be on the same layer as everything else (absolute positioning and floating something throws it out of the normal flow of the DOM into it's own special layer)
[23:02:22] <ashley>	 hacky floats...yep, sounds like MediaWiki, alright :P
[23:02:47] <SamanthaNguyen>	 sadly :P
[23:03:41] <SamanthaNguyen>	 hmm SpecialAddRelationships.php seems to load the CSS module, ext.socialprofile.clearfix, but the UserRelationship module doesn't actually use it
[23:04:09] <SamanthaNguyen>	 (SpecialViewRelationshipRequests.php also loads it but doesn't use it)
[23:14:45] <SamanthaNguyen>	 ashley: Hoping that this won't take nearly as long as the other technical debt ticket (the wgSupress one) :P
[23:14:49] <SamanthaNguyen>	 *I'm hoping
[23:15:11] <ashley>	 probably because at one point those special pages used to load the module's (whereas by module I mean UserProfile, UserRelationship, SystemGifts, etc.) main CSS file which included the clear-related rules; when I refactored that stuff into one file (SocialProfile/shared/clearfix.css) I didn't check whether all the special pages (etc.) were actually using one or more of those classes
[23:16:17] <SamanthaNguyen>	 about to push out a patch for that ;-) refactoring UserProfile (which is the only module that uses clearfix now) will be in another patch
[23:17:12] <ashley>	 nifty :D
[23:18:06] <SamanthaNguyen>	 ashley: https://gerrit.wikimedia.org/r/334854 tada!
[23:19:05] <SamanthaNguyen>	 well, only SpecialUpdateProfile, UserProfileHooks, and UserProfilePage uses it, but at least the special page EditProfile doesn't use it :P
[23:21:02] <ashley>	 https://gerrit.wikimedia.org/r/#/c/334854/1/UserRelationship/SpecialViewRelationships.php <-- seems like an empty newline?
[23:21:22] <SamanthaNguyen>	 oops :P
[23:22:14] <SamanthaNguyen>	 updated
[23:22:52] <ashley>	 cheers; I +2'd the BlogPage patch (didn't test it, but I *think* it shouldn't break anything ;P)
[23:23:18] <SamanthaNguyen>	 yeah honestly there should be no way for it to break :P
[23:25:00] <SamanthaNguyen>	 oh btw jsyk, Umheirrender merged the patch for WikiCategoryTagCloud earlier today :-)
[23:27:34] <ashley>	 \o/
[23:30:35] <SamanthaNguyen>	 ashley: oops, can you -2 it real quick?
[23:30:41] <SamanthaNguyen>	 forgot to add UserBoard
[23:30:56] <SamanthaNguyen>	 oh nvm, oh well :P
[23:31:04] <SamanthaNguyen>	 i'll add it in a second patch, sorry :P
[23:31:35] <ashley>	 no worries :-)
[23:33:26] <SamanthaNguyen>	 ashley: https://gerrit.wikimedia.org/r/334855
[23:34:17] <SamanthaNguyen>	 oh btw, Filip's patch should be good to go now since I +1'd it: https://gerrit.wikimedia.org/r/#/c/334378/
[23:36:19] <ashley>	 +2'd
[23:36:34] <SamanthaNguyen>	 sweet :D thanks
[23:37:34] <ashley>	 thank *you* for working on all this stuff, reviewing patches, etc. -- it's no easy job, but it's certainly necessary!
[23:39:52] <SamanthaNguyen>	 heheh, np :D I actually kinda like it, it makes me feel productive :P plus coding is fun (at least most of the time :P )
[23:45:00] <ashley>	 it just doesn't make you *feel* productive, it makes you literally productive ;-) and let's face it, you've gotten more things done over the past couple weeks than I have in a rather long time, especially wrt. technical debt
[23:45:41] <SamanthaNguyen>	 honestly I'm glad Filip has submitted patches and has knowledge on OOUI, it actually made me more interested in writing with OOUI (I think before I was a little intimidated by the entire framework, but his patch showed me that the framework is actually pretty easy to use)
[23:46:17] <SamanthaNguyen>	 ashley: heh, thanks :) if i was only this productive with schoolwork
[23:46:22] <SamanthaNguyen>	 that's another story :P
[23:46:29] <ashley>	 haha, I know the feeling all too well :p
[23:47:11] <ashley>	 (I need to finish one brief essay -- it's like 99% done, so there's that -- and study for an exam I have on Monday...for a university exam, there isn't even that much stuff to read, but, well, it's not like I've started reading either >.>)
[23:48:26] <SamanthaNguyen>	 only 1% more, you can do it! :D 
[23:49:27] <SamanthaNguyen>	 yeah..I need to catchup on a book called Things Fall Apart by Chinua Achebe, I've read 19 of the chapters so far, I just need to read 6 more chapters (luckily each one are only a couple pages long)
[23:51:18] <ashley>	 sounds more interesting than sociology :p
[23:53:32] <SamanthaNguyen>	 heh, i suppose so :P i'm actually considering to take it next year along with psychology
[23:53:36] <SamanthaNguyen>	 just to try it out :P
[23:53:54] <SamanthaNguyen>	 not sure yet though ¯\_(ツ)_/¯
[23:54:48] <SamanthaNguyen>	 brb in 10-20ish mins o/